Abort if upload returns a non 200 http status #8

varshavaradarajan · 2019-10-14T15:57:27Z

@skx - curl returning a non zero exit code does not happen if the GitHub upload request times out, or as mentioned in #6 , is a 404. I think both cases (curl exiting with non zero and post not being successful) should be handled. WDYT?

skx · 2019-10-14T16:02:15Z

Yes, I noted that in the release - though I didn't notice it in your original report:

However I suspect this won't be comprehensive, because the curl command could complete and regard itself as successful even if the remote API returns "out of disk-space", "artifact already present", or some other error-condition. We're solely relying upon the exit-code that curl returns here.

Your change looks good. Thank you for your continued attention.

varshavaradarajan · 2019-10-14T16:15:56Z

Thanks @skx! Verified that it works ~~https://github.com/varshavaradarajan/clusterlint/commit/56e3306cf7dee1dcd6955519936a93d70182b71d/checks?check_suite_id=264339268~~

Edit: Reran checks, so above url no longer valid.

Abort if upload returns a non 200 http status

24fe9d9

skx merged commit 6a9ddcf into skx:master Oct 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Abort if upload returns a non 200 http status #8

Abort if upload returns a non 200 http status #8

Abort if upload returns a non 200 http status #8

Abort if upload returns a non 200 http status #8

Conversation