Added an input for a release id and updated bash script to handle a s… #21

wattry · 2020-05-08T17:07:31Z

…econd argument for the release id

upload-script

…econd argument

skx · 2020-05-14T05:00:14Z

Thanks for updating the argument parsing.

However I've realized there is a problem with positional arguments as I've used this script on a lot of projects. e.g. I've got it here:

There you'll see I use a glob puppet-* and that means the script gets invoked as:

 $ script puppet-summary-linux-amd64 puppet-summary-linux-i386  ...

That means we must use getopt. So we'll have a script accept/not the release like so:

 $ script -release=foo arg1
 $ script arg1 arg2

If you could make a change to use getopt then I'll merge. If not I'll merge and fixup tomorrow rather than leaving this open for too long.

Sorry for only just realizing this, and thank-you once again for the update :)

skx · 2020-05-14T05:14:33Z

I'm an idiot - we can use the environmental variables.

I'll fixup.

skx · 2020-05-14T05:23:58Z

Fixed up in 75ce554

Tested here:

Hope this works for you :)

wattry · 2020-05-14T10:11:41Z

@skx I'm in the GMT-6 time zone so don't worry I only just woke up. Thanks again!

skx reviewed May 9, 2020

View reviewed changes

upload-script Outdated Show resolved Hide resolved

Added an input for a release id and updated bash script to handle a s…

430e163

…econd argument

skx merged commit faf5941 into skx:master May 14, 2020

Provide feedback