8000 📝 Improve doc: remove double quotes from hash key by yamashush · Pull Request #1685 · slackapi/bolt-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

📝 Improve doc: remove double quotes from hash key #1685

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 18, 2022
Merged

📝 Improve doc: remove double quotes from hash key #1685

merged 4 commits into from
Dec 18, 2022

Conversation

yamashush
Copy link
Contributor
@yamashush yamashush commented Dec 18, 2022 •
edited
Loading

Summary

This PR is improving docs 📝
Remove double quotes from hash key, aligned with other sample code 😄

before

          {
            "type": "section",
            "text": {
              "type": "mrkdwn",
              "text": "*Welcome home, <@" + event.user + "> :house:*"
            }
          },

after

          {
            type: "section",
            text: {
              type: "mrkdwn",
              text: "*Welcome home, <@" + event.user + "> :house:*"
            }
          },

Requirements (place an x in each [ ])

@codecov
Copy link
codecov bot commented Dec 18, 2022

Codecov Report

Merging #1685 (33ba34d) into main (dac17f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1685   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          18       18           
  Lines        1502     1502           
  Branches      437      437           
=======================================
  Hits         1233     1233           
  Misses        172      172           
  Partials       97       97

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch self-assigned this Dec 18, 2022
@seratch seratch added the docs M-T: Documentation work only label Dec 18, 2022
@seratch seratch added this to the 3.12.3 milestone Dec 18, 2022
seratch
seratch approved these changes Dec 18, 2022
View reviewed changes
Copy link
Contributor
@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thank you!

@seratch seratch merged commit c465846 into slackapi:main Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees

@seratch seratch

Labels
docs M-T: Documentation work only
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yamashush @seratch
0