8000 📄 Update Japanese OAuth docs by yamashush · Pull Request #1697 · slackapi/bolt-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

📄 Update Japanese OAuth docs #1697

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Dec 26, 2022
Merged

Conversation

yamashush
Copy link
Contributor

Summary

I have updated Japanese OAuth docs to reflect below changes ✏️

Requirements (place an x in each [ ])

@codecov
Copy link
codecov bot commented Dec 24, 2022

Codecov Report

Merging #1697 (7e08155) into main (24b4f2f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1697   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          18       18           
  Lines        1502     1502           
  Branches      437      437           
=======================================
  Hits         1233     1233           
  Misses        172      172           
  Partials       97       97           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch added the docs M-T: Documentation work only label Dec 26, 2022
@seratch seratch added this to the 3.12.3 milestone Dec 26, 2022
Copy link
Contributor
@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Th 8000 anks a lot for improving this! Could you check my comments?

@@ -30,6 +30,7 @@ const app = new App({
installationStore: new FileInstallationStore(),
});
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert all the changes to the English page?

@seratch seratch self-assigned this Dec 26, 2022
yamashush and others added 14 commits December 26, 2022 16:28
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
yamashush and others added 8 commits December 26, 2022 16:41
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
@yamashush
Copy link
Contributor Author

Thank you very very much for review and suggestion!!
@seratch I fixed it ✏️

Copy link
Contributor
@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch merged commit bf374b6 into slackapi:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0