8000 ci: complete all sample tests even if one fails fast by zimeg · Pull Request #2386 · slackapi/bolt-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: complete all sample tests even if one fails fast #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2025
Merged

ci: complete all sample tests even if one fails fast #2386

merged 3 commits into from
Jan 9, 2025

Conversation

zimeg
Copy link
Member
@zimeg zimeg commented Jan 8, 2025

Summary

This PR runs all of the sample tests to completion even if one fails fast. This is useful in finding if a test is failing for a certain sample or version of Node 👁️‍🗨️

Preview

Before this change is shown below:

before

Requirements

@zimeg zimeg added tests M-T: Testing work only github_actions Pull requests that update GitHub Actions code labels Jan 8, 2025
@zimeg zimeg self-assigned this Jan 8, 2025
@zimeg
Copy link
Member Author
zimeg commented Jan 8, 2025 
npm error code ECONNRESET
npm error errno ECONNRESET
npm error network Invalid response body while trying to fetch https://registry.npmjs.org/@types%2fnode: aborted
npm error network This is a problem related to network connectivity.
npm error network In most cases you are behind a proxy or have bad network settings.
npm error network
npm error network If you are behind a proxy, please make sure that the
npm error network 'proxy' config is set properly.  See: 'npm help config'
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/202[5](https://github.com/slackapi/bolt-js/actions/runs/12678404454/job/35335911391?pr=2386#step:4:6)-01-08T20_22_46_296Z-debug-0.log

Hmmm... This Node.js CI / build (18.x) (pull_request) to Node 18 🤔

A few other errors with samples are appearing, but I'll investigate these. For now, here's what the update shows as!:

after

@zimeg zimeg marked this pull request as draft January 8, 2025 20:28
@codecov Codecov
Copy link
codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (2d26011) to head (e3124eb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2386   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      653      653           
=======================================
  Hits         6919     6919           
  Misses        545      545           
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg zimeg marked this pull request as ready for review January 8, 2025 22:26
WilliamBergamin
WilliamBergamin approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor
@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this behavior 👍
This can help to quickly determine which samples/examples are affected by a given change. Especially in the scenario where dependabot updates dependencies

@zimeg
Copy link
Member Author
zimeg commented Jan 9, 2025

@WilliamBergamin Thanks for calling out the multiplication of matrix updates from @dependabot! 👾

I think a fun follow-up PR will put this all of the test after this is merged 👀

@zimeg zimeg merged commit b475b05 into main Jan 9, 2025
16 checks passed
@zimeg zimeg deleted the zimeg-ci-samples-fail-fast-false branch January 9, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

@seratch seratch Awaiting requested review from seratch

Assignees

@zimeg zimeg

Labels
github_actions Pull requests that update GitHub Actions code tests M-T: Testing work only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimeg @WilliamBergamin
0