8000 docs: rotate tokens on a separate schedule with the oauth package by zimeg · Pull Request #2558 · slackapi/bolt-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: rotate tokens on a separate schedule with the oauth package #2558

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

docs: rotate tokens on a separate schedule with the oauth package #2558

merged 2 commits into from
Jun 9, 2025

Conversation

zimeg
Copy link
Member
@zimeg zimeg commented May 30, 2025

Summary

This PR adds example reference of unscheduled token rotation to follow up on questions from #2555 📚 ✨

Preview

rotations

Requirements

@zimeg zimeg self-assigned this May 30, 2025
@zimeg zimeg added the docs M-T: Documentation work only label May 30, 2025
@codecov Codecov
Copy link
codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (ddc2f59) to head (3096287).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2558   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          37       37           
  Lines        7575     7575           
  Branches      664      664           
=======================================
  Hits         7072     7072           
  Misses        498      498           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mwbrooks
mwbrooks approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member
@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Pfff... amazing addition! I know this is a common pain-point for developers and the explicit code sample is really going to help people! 👌🏻

@zimeg
Copy link
Member Author
zimeg commented Jun 9, 2025

@mwbrooks Thanks so much! 💌 But all credit to @yulianovdey for pointing out this gap in documentation 📚 ✨

I find more and more often that quick examples and constant iterations make these surfaces better so I will merge this now 😌 🎉

@zimeg zimeg merged commit d6051f6 into main Jun 9, 2025
20 checks passed
@zimeg zimeg deleted the zimeg-docs-token-rotation-unscheduled branch June 9, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@lukegalbraithrussell lukegalbraithrussell Awaiting requested review from lukegalbraithrussell

Assignees

@zimeg zimeg

Labels
docs M-T: Documentation work only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimeg @mwbrooks
0