8000 Renew after expiry by maraino · Pull Request #647 · smallstep/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Renew after expiry #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 13, 2022
Merged

Renew after expiry #647

merged 17 commits into from
Apr 13, 2022

Conversation

maraino
Copy link
Collaborator
@maraino maraino commented Mar 9, 2022

Description

This PR adds the necessary changes to step to support the renewal of certificates after expiry.

Requires:

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Mar 9, 2022
@maraino maraino requested a review from dopey March 15, 2022 19:14
@maraino maraino marked this pull request as ready for review March 15, 2022 19:14
Copy link
Contributor
@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

maraino added 7 commits April 13, 2022 12:20
Instead of using the provisioner name as an issuer, the renew and
admin tokens generated by the cli will have a fixed string because
in specific cases, like an RA mode there's no guarantee that the RA
will have a provisioner with the same name configured.
@maraino maraino requested a review from dopey April 13, 2022 22:28
Copy link
Contributor
@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maraino maraino merged commit b6adb57 into master Apr 13, 2022
@maraino maraino deleted the feat/renewAfterExpiry branch April 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0