This repository was archived by the owner on Aug 2, 2024. It is now read-only.
Modernize polaris-link component #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpye
approved these changes
Feb 18, 2020
vladucu
approved these changes
Feb 18, 2020
| class={{linkClass}} | ||
| {{action (action onClick) bubbles=false}} | ||
| class={{this.linkClass}} | ||
| {{on "click" (stop-propagation (or @onClick this.onClick))}} |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV-69
Updates
PolarisLinkto tagless component, ES6 classes, and angle bracket syntax.Notable change:
ember-event-helpersto use with theonmodifier so we can stop propagation via template helper.