This repository was archived by the owner on Aug 2, 2024. It is now read-only.
Modernize empty-state component #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomnez
approved these changes
Jun 22, 2020
| * @type {Object} | ||
| * @default null | ||
| */ | ||
| action: null, | ||
| action = null; |
There was a problem hiding this comment.
Does this break in our version of Ember here? I thought we had to update the use of attributes named action at some point in our Ember upgrades but maybe I'm remembering wrong.
There was a problem hiding this comment.
good catch.... it seems to work, but we should probably do this just to avoid confusions
have this noted to recheck once all components are done
| <PolarisButton | ||
| @plain={{true}} | ||
| @text={{@secondaryAction.text}} | ||
| @ @secondaryAction.onAction}} |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.