8000 Use ember-cli-htmlbars in tests by vladucu · Pull Request #654 · smile-io/ember-polaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 2, 2024. It is now read-only.

Use ember-cli-htmlbars in tests #654

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Use ember-cli-htmlbars in tests #654

merged 1 commit into from
Sep 23, 2020

Conversation

vladucu
Copy link
Member
@vladucu vladucu commented Sep 23, 2020

Starts using ember-cli-htmlbars instead of the deprecated
htmlbars-inline-precompile. Changes are the result of running the
codemod

@vladucu
Use ember-cli-htmlbars in tests
83a9409 
Starts using `ember-cli-htmlbars` instead of the deprecated
`htmlbars-inline-precompile`.  Changes are the result of running the
[codemod](https://github.com/ember-codemods/ember-cli-htmlbars-inline-precompile-codemod)
@vladucu vladucu self-assigned this Sep 23, 2020
@vladucu vladucu requested a review from andrewpye September 23, 2020 13:42
andrewpye
andrewpye approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member
@andrewpye andrewpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me if tests pass! 🚀

@vladucu vladucu merged commit b96917d into master Sep 23, 2020
@vladucu vladucu deleted the run-ember-cli-htmlbars-inline-precompile-codemod branch September 23, 2020 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewpye andrewpye andrewpye approved these changes

Assignees

@vladucu vladucu

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladucu @andrewpye
0