10000 chore: cleanup obsolete code by PeterSchafer · Pull Request #79 · snyk/code-client-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: cleanup obsolete code #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

chore: cleanup obsolete code #79

merged 1 commit into from
Mar 4, 2025

Conversation

PeterSchafer
Copy link
Contributor

Description

Cleanup unused legacy code

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing

🚨After having merged, please update the snyk-ls and CLI go.mod to pull in latest client.

@PeterSchafer PeterSchafer requested review from a team as code owners March 3, 2025 13:42
@michelkaporin
Copy link

I presume this change drops contract testing altogether, is that correct?

If so, https://github.com/snyk/code-client-go/blame/main/.circleci/config.yml#L105 would have to be tidied up too. And we need to remove on workspace-service side it as well, if contract testing isn't used any more.

From the learning perspective, has Pact been helpful for your team to spot issues, or has it remained transparent since it was introduced by @teodora-sandu ?

@PeterSchafer
Copy link
Contributor Author
PeterSchafer commented Mar 4, 2025 •
edited
Loading

I presume this change drops contract testing altogether, is that correct?

If so, https://github.com/snyk/code-client-go/blame/main/.circleci/config.yml#L105 would have to be tidied up too. And we need to remove on workspace-service side it as well, if contract testing isn't used any more.

From the learning perspective, has Pact been helpful for your team to spot issues, or has it remained transparent since it was introduced by @teodora-sandu ?

Since the library doesn't use the workspace service anymore, it seems reasonable to remove these.

If there is broader support for contract testing in the org and for the used API we would make use of it but for now it doesn't provide enough value and is single sided only.

@PeterSchafer PeterSchafer reopened this Mar 4, 2025
@michelkaporin
Copy link

If there is broader support for contract testing in the org and for the used API we would make use of it but for now it doesn't provide enough value and is single sided only.

No objections to remove it, I am curious on the experience you've had with it. That can inform how much useful may it be for the broader R&D support :) If there's anything more you can share about it, would be great.

@PeterSchafer PeterSchafer merged commit 656acc7 into main Mar 4, 2025
13 checks passed
@PeterSchafer PeterSchafer deleted the chore/CLI-738 branch March 4, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelkaporin michelkaporin michelkaporin approved these changes

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

Assignees
No one assigned
Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterSchafer @michelkaporin @bastiandoetsch
0