test: add test stub for DeepCodeLLMBindingImpl #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if a generated mock would be better for the http layer? |
miri-yehezkel
commented
Apr 2, 2025
There was a problem hiding this comment.
dumb question: why not gomock? have you seen http/mocks?
There was a problem hiding this comment.
have you seen
http/mocks?
Not silly at all, I did miss it!
If I understand correctly this would mean the PR is not needed. Testing on my service 🙏
LMK if you think I missed something and would need to abstract something in the library :)
There was a problem hiding this comment.
@bastiandoetsch thanks for calling out http/mocks! I used it on our service to test the library :)
Closing this PR 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
FakeDeepCodeLLMBindingImpl, used to stub testsChecklist
README.md updated, if user-facing🚨After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.