8000 fix: explain result order by ShawkyZ · Pull Request #98 · snyk/code-client-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: explain result order #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 29, 2025
Merged

fix: explain result order #98

merged 9 commits into from
Apr 29, 2025

Conversation

ShawkyZ
Copy link
Contributor
@ShawkyZ ShawkyZ commented Apr 25, 2025 •
edited
Loading

Description

Changes:

  • EnrichWithExplain sends back a slice instead of a Map.
  • Before sending diffs to the backend, remove the first two lines if they contain "---", "+++" since the LLM doesn't need them and it's unnecessary tokens.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing

🚨After having merged, please update the snyk-ls and CLI go.mod to pull in latest client.

@github-actions github-actions bot added the fix label Apr 25, 2025
ShawkyZ
ShawkyZ commented Apr 25, 2025
View reviewed changes
@ShawkyZ ShawkyZ force-pushed the fix/explain-order branch from 5554c86 to 0c6b240 Compare April 28, 2025 16:35
@github-actions github-actions bot added fix and removed fix labels Apr 28, 2025
@ShawkyZ ShawkyZ changed the title fix: explanation order fix: explain result order Apr 28, 2025
@github-actions github-actions bot added fix and removed fix labels Apr 28, 2025
@miri-yehezkel miri-yehezkel marked this pull request as ready for review April 29, 2025 11:31
@miri-yehezkel miri-yehezkel requested review from a team as code owners April 29, 2025 11:31
ShawkyZ
ShawkyZ commented Apr 29, 2025
View reviewed changes
@miri-yehezkel miri-yehezkel merged commit 8187e9c into main Apr 29, 2025
12 checks passed
@miri-yehezkel miri-yehezkel deleted the fix/explain-order branch April 29, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acke acke acke approved these changes

@miri-yehezkel miri-yehezkel miri-yehezkel approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShawkyZ @acke @miri-yehezkel
0