8000 migrate some more resource to new resource handling by moadibfr Β· Pull Request #478 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

migrate some more resource to new resource handling #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 18, 2021
Merged

migrate some more resource to new resource handling #478

merged 6 commits into from
May 18, 2021

Conversation

moadibfr
Copy link
Contributor
Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? yes
❌ BC Break yes
πŸ”— Related issues #347
❓ Documentation no

Description

migrate sqs-queue
migrate sqs_queue_policy and sqs_default_queue_policy
migrate subnet and default subnet
migrate vpc

@moadibfr moadibfr requested a review from a team as a code owner April 30, 2021 17:36
@codecov
Copy link
codecov bot commented Apr 30, 2021 •
edited
Loading

Codecov Report

Merging #478 (3fcd1d9) into main (d72cc3d) will increase coverage by 0.00%.
The diff coverage is 93.54%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   69.75%   69.75%           
=======================================
  Files         292      292           
  Lines        6893     6904   +11     
=======================================
+ Hits         4808     4816    +8     
- Misses       1727     1733    +6     
+ Partials      358      355    -3
Impacted Files Coverage Ξ”
pkg/resource/aws/aws_default_subnet.go 100.00% <ΓΈ> (+66.66%) ⬆️
pkg/resource/resource.go 65.97% <ΓΈ> (ΓΈ)
pkg/resource/aws/aws_sqs_queue_policy.go 83.33% <77.77%> (-16.67%) ⬇️
pkg/driftctl.go 72.28% <100.00%> (+0.33%) ⬆️
pkg/middlewares/aws_default_sqs_queue_policy.go 100.00% <100.00%> (ΓΈ)
pkg/middlewares/aws_sqs_queue_policy_expander.go 94.44% <100.00%> (+8.73%) ⬆️
pkg/resource/aws/aws_subnet.go 100.00% <100.00%> (+33.33%) ⬆️
pkg/resource/aws/metadatas.go 100.00% <100.00%> (ΓΈ)
pkg/resource/aws/aws_sqs_queue_ext.go 0.00% <0.00%> (-60.00%) ⬇️
pkg/resource/aws/aws_sqs_queue_policy_ext.go 0.00% <0.00%> (-60.00%) ⬇️
... and 3 more

@moadibfr moadibfr force-pushed the fea/new_resource_migration branch 6 times, most recently from 2017615 to 09b79b0 Compare May 7, 2021 16:39
eliecharra
eliecharra reviewed May 10, 2021
View reviewed changes
Copy link
Contributor
@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks

@moadibfr moadibfr force-pushed the fea/new_resource_migration branch 3 times, most recently from 8c56aca to cf527ab Compare May 11, 2021 14:31
@moadibfr moadibfr requested a review from eliecharra May 12, 2021 08:14
wbeuil
wbeuil suggested changes May 17, 2021
View reviewed changes
8000 pkg/resource/aws/metadatas.go Outdated
@@ -26,4 +26,7 @@ func InitResourcesMetadata(resourceSchemaRepository resource.SchemaRepositoryInt
initAwsIAMUserMetaData(resourceSchemaRepository)
initAwsIAMUserPolicyMetaData(resourceSchemaRepository)
initAwsKeyPairMetaData(resourceSchemaRepository)
initAwsSubnetMetaData(resourceSchemaRepository)
initAwsDefaultSubnetMetaData(resourceSchemaRepository)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the one line 11.

@moadibfr moadibfr force-pushed the fea/new_resource_migration branch from cf527ab to ce98460 Compare May 17, 2021 16:58
@moadibfr moadibfr requested a review from wbeuil May 17, 2021 16:59
@eliecharra eliecharra merged commit 58d8195 into main May 18, 2021
@eliecharra eliecharra deleted the fea/new_resource_migration branch May 18, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

@wbeuil wbeuil wbeuil approved these changes

< 4E6B form class="js-issue-sidebar-form" aria-label="Select assignees" data-turbo="false" action="/snyk/driftctl/issues/478/assignees" accept-charset="UTF-8" method="post">
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moadibfr @eliecharra @wbeuil
0