8000 Add ecr | route_table | route by wbeuil · Pull Request #499 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ecr | route_table | route #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2021
Merged

Add ecr | route_table | route #499

merged 3 commits into from
May 10, 2021

Conversation

wbeuil
Copy link
Contributor
@wbeuil wbeuil commented May 7, 2021 •
edited
Loading 
aws_ecr_repository
aws_route_table
aws_route

⚠️ I don't recall we spoke about the Stringer so I commented for now the method for the aws_route.

@wbeuil wbeuil requested a review from a team as a code owner May 7, 2021 18:57
@codecov
Copy link
codecov bot commented May 7, 2021 •
edited
Loading

Codecov Report

Merging #499 (6a25575) into main (b924fe8) will decrease coverage by 0.41%.
The diff coverage is 93.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   70.42%   70.01%   -0.42%     
==========================================
  Files         290      290              
  Lines        6750     6749       -1     
==========================================
- Hits         4754     4725      -29     
- Misses       1626     1658      +32     
+ Partials      370      366       -4
Impacted Files Coverage Δ
pkg/resource/resource.go 67.18% <ø> (ø)
pkg/resource/aws/aws_route.go 92.00% <90.90%> (-8.00%) ⬇️
pkg/middlewares/aws_route_table_expander.go 92.03% <93.44%> (+2.10%) ⬆️
pkg/middlewares/aws_default_igw_route.go 78.57% <100.00%> (-0.74%) ⬇️
pkg/middlewares/aws_default_route.go 100.00% <100.00%> (ø)
pkg/resource/aws/aws_ecr_repository.go 100.00% <100.00%> (+33.33%) ⬆️
pkg/resource/aws/metadatas.go 100.00% <100.00%> (ø)
pkg/resource/aws/aws_route_ext.go 13.88% <0.00%> (-80.56%) ⬇️
pkg/resource/aws/aws_route_table_ext.go 0.00% <0.00%> (-33.34%) ⬇️

@eliecharra
Copy link
Contributor

⚠️ I don't recall we spoke about the Stringer so I commented for now the method for the aws_route.

For now we do not have a mechanism to handle this, we'll do another pass of refactoring when @lotoussa's PR will be merged to main

@eliecharra eliecharra merged commit 517c656 into main May 10, 2021
@eliecharra eliecharra deleted the refacto-res branch May 10, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbeuil @eliecharra
0