Fix crash when capacity is set to 0 in cache #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
=======================================
Coverage 71.94% 71.95%
=======================================
Files 196 196
Lines 5825 5827 +2
=======================================
+ Hits 4191 4193 +2
Misses 1381 1381
Partials 253 253
|
lotoussa
previously approved these changes
Jun 4, 2021
wbeuil
suggested changes
Jun 4, 2021
9fbd8e5 to
1d53724
Compare
1d53724 to
26dcfd2
Compare
wbeuil
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, we may want to not use the cache although it's required. It may be for testing purposes or simply because of a technical limitation. We already use a capacity of 0 in supplier unit tests, because we don't need to cache values. For now, a capacity of 0 result in a nil pointer dereference error. This PR fixes the issue simply by ignoring keys when capacity is set to 0.