8000 Fix unsupported resources read from state files by eliecharra Β· Pull Request #591 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix unsupported resources read from state files #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2021
Merged

Fix unsupported resources read from state files #591

merged 1 commit into from
Jun 4, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues none
❓ Documentation no

@eliecharra eliecharra added the kind/bug Something isn't working label Jun 4, 2021
@eliecharra eliecharra added this to the v0.10.0 milestone Jun 4, 2021
@eliecharra eliecharra requested a review from a team as a code owner June 4, 2021 10:05
@codecov
Copy link
codecov bot commented Jun 4, 2021

Codecov Report

Merging #591 (c1770ac) into main (8ea1af5) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   71.96%   71.94%   -0.02%     
==========================================
  Files         196      196              
  Lines        5821     5825       +4     
==========================================
+ Hits         4189     4191       +2     
- Misses       1380     1381       +1     
- Partials      252      253       +1
Impacted Files Coverage Ξ”
pkg/iac/terraform/state/terraform_state_reader.go 65.11% <0.00%> (-1.03%) ⬇️
pkg/resource/resource_types.go 100.00% <100.00%> (ΓΈ)

@eliecharra eliecharra merged commit fc7838b into main Jun 4, 2021
@eliecharra eliecharra deleted the fix_unsupported_resource branch June 4, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadibfr moadibfr moadibfr approved these changes

@wbeuil wbeuil wbeuil approved t 5461 hese changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eliecharra @moadibfr @wbeuil
0