8000 Retrieve provider version and schema version by eliecharra Β· Pull Request #607 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Retrieve provider version and schema version #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2021
Merged

Retrieve provider version and schema version #607

merged 1 commit into from
Jun 14, 2021

Conversation

eliecharra
Copy link
Contributor
@eliecharra eliecharra commented Jun 9, 2021 •
edited
Loading
Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #446 #457
❓ Documentation no

Description

Allow to retrieve the provider version and schema version to be used to handle provider issues only for a specific version

@eliecharra eliecharra requested a review from patch-the-dog June 9, 2021 15:30
@eliecharra eliecharra requested a review from a team as a code owner June 9, 2021 15:30
@eliecharra eliecharra added the kind/enhancement New feature or improvement label Jun 9, 2021
@eliecharra eliecharra added this to the v0.10.0 milestone Jun 9, 2021
@eliecharra eliecharra removed the request for review from patch-the-dog June 9, 2021 15:30
@eliecharra eliecharra marked this pull request as draft June 9, 2021 15:32
sundowndev
sundowndev previously approved these changes Jun 9, 2021
View reviewed changes
@codecov
Copy link
codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #607 (35b511e) into main (5790225) will decrease coverage by 0.05%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   72.14%   72.09%   -0.06%     
==========================================
  Files         198      198              
  Lines        6032     6042      +10     
==========================================
+ Hits         4352     4356       +4     
- Misses       1415     1420       +5     
- Partials      265      266       +1
Impacted Files Coverage Ξ”
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/aws/provider.go 0.00% <ΓΈ> (ΓΈ)
pkg/remote/github/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/github/provider.go 7.69% <ΓΈ> (+0.54%) ⬆️
pkg/resource/schemas.go 89.58% <71.42%> (-3.28%) ⬇️

@eliecharra eliecharra force-pushed the retrieve_provider_versions branch from 4baa86d to 08704b1 Compare June 9, 2021 15:35
@eliecharra eliecharra marked this pull request as ready for review June 9, 2021 15:35
@eliecharra eliecharra force-pushed the retrieve_provider_versions branch from 08704b1 to 2ec3201 Compare June 10, 2021 08:45
@sundowndev sundowndev self-assigned this Jun 10, 2021
@sundowndev sundowndev force-pushed the retrieve_provider_versions branch from 2ec3201 to 35b511e Compare June 14, 2021 09:02
@sundowndev sundowndev merged commit d4b4ed9 into main Jun 14, 2021
@sundowndev sundowndev deleted the retrieve_provider_versions branch June 14, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees

@sundowndev sundowndev

Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @sundowndev
0