8000 Allow to override OS_ARCH in build script by eliecharra · Pull Request #652 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow to override OS_ARCH in build script #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2021
Merged

Allow to override OS_ARCH in build script #652

merged 1 commit into from
Jun 17, 2021

Conversation

eliecharra
Copy link
Contributor

Allows us to cross compile a specific version locally :

➜ OS_ARCH=windows/amd64 make build
scripts/build.sh
Bash: 5.1.8(1)-release
+ Building env: dev
ARCH: windows/amd64
+ Removing old binaries ...
+ Building with flags: -X github.com/cloudskiff/driftctl/pkg/version.version=7fe9b13d
Number of parallel builds: 2

-->   windows/amd64: github.com/cloudskiff/driftctl

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Jun 15, 2021
@eliecharra eliecharra added this to the v0.10.0 milestone Jun 15, 2021
@eliecharra eliecharra requested a review from a team June 15, 2021 16:27
@codecov
Copy link
codecov bot commented Jun 15, 2021

Codecov Report

Merging #652 (2637718) into main (f206ff9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #652   +/-   ##
=======================================
  Coverage   72.09%   72.09%           
=======================================
  Files         198      198           
  Lines        6042     6042           
=======================================
  Hits         4356     4356           
  Misses       1420     1420           
  Partials      266      266

@eliecharra eliecharra merged commit f7e08bb into main Jun 17, 2021
@eliecharra eliecharra deleted the improve_build_script branch June 17, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

@sundowndev sundowndev sundowndev approved these changes

Assignees
5054 No one assigned
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eliecharra @wbeuil @sundowndev
0