8000 Fix EBS volume drift on throughput by eliecharra Β· Pull Request #664 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix EBS volume drift on throughput #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2021
Merged

Fix EBS volume drift on throughput #664

merged 1 commit into from
Jun 18, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #612
❓ Documentation no

@eliecharra eliecharra added the kind/bug Something isn't working label Jun 18, 2021
@eliecharra eliecharra added this to the v0.10.0 milestone Jun 18, 2021
@eliecharra eliecharra requested a review from a team June 18, 2021 09:14
@eliecharra eliecharra force-pushed the fix_ebs_block_device branch from 9e368e6 to f6b6926 Compare June 18, 2021 09:17
wbeuil
wbeuil suggested changes Jun 18, 2021
View reviewed changes
pkg/resource/aws/aws_instance_test.go Outdated
}
result.AssertDeletedCount(0)
result.AssertManagedCount(2)
result.AssertDriftCountTotal(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

result.AssertInfrastructureIsInSync()
result.AssertManagedCount(2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this is more straightforward, fixed

@codecov
Copy link
codecov bot commented Jun 18, 2021 •
edited
Loading

Codecov Report

Merging #664 (8751bda) into main (4ac335e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   72.21%   72.21%           
=======================================
  Files         198      198           
  Lines        6057     6058    +1     
=======================================
+ Hits         4374     4375    +1     
  Misses       1416     1416           
  Partials      267      267
Impacted Files Coverage Ξ”
pkg/resource/aws/aws_ebs_volume.go 100.00% <100.00%> (ΓΈ)

@eliecharra eliecharra force-pushed the fix_ebs_block_device branch from f6b6926 to 8751bda Compare June 18, 2021 09:25
@eliecharra eliecharra requested a review from wbeuil June 18, 2021 09:25
@wbeuil wbeuil merged commit 19bea9f into main Jun 18, 2021
@wbeuil wbeuil deleted the fix_ebs_block_device branch June 18, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @wbeuil
0