8000 Display elapsed time at end of scan by sundowndev Β· Pull Request #682 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Display elapsed time at end of scan #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

Display elapsed time at end of scan #682

merged 1 commit into from
Jun 22, 2021

Conversation

sundowndev
Copy link
Contributor
@sundowndev sundowndev commented Jun 22, 2021 •
edited
Loading
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #550
❓ Documentation no

Description

This PR adds a simple message at the end of the scan to tell the user how much time it took to scan their entire infrastructure.

Scanned states (1) 
Found 3 resource(s)    
 - 100% coverage
Congrats! Your infrastructure is fully in sync.
Done in 8s
Provider version used to scan: 3.19.0. Use --tf-provider-version to use another version.

@sundowndev sundowndev requested a review from a team as a code owner June 22, 2021 15:06
@codecov
Copy link
codecov bot commented Jun 22, 2021

Codecov Report

Merging #682 (cba595d) into main (797f527) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   72.62%   72.61%   -0.02%     
==========================================
  Files         200      200              
  Lines        6133     6134       +1     
==========================================
  Hits         4454     4454              
- Misses       1413     1414       +1     
  Partials      266      266
Impacted Files Coverage Ξ”
pkg/cmd/scan.go 82.33% <0.00%> (-0.32%) ⬇️

eliecharra
eliecharra suggested changes Jun 22, 2021
View reviewed changes
@eliecharra eliecharra merged commit d115650 into main Jun 22, 2021
@eliecharra eliecharra deleted the feat/elapsedTime branch June 22, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sundowndev @eliecharra
0