8000 split sns_topic_policy_supplier by moadibfr · Pull Request #810 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

split sns_topic_policy_supplier #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

split sns_topic_policy_supplier #810

merged 1 commit into from
Jul 8, 2021

Conversation

moadibfr
Copy link
Contributor
@moadibfr moadibfr commented Jul 6, 2021

No description provided.

@moadibfr moadibfr requested a review from a team as a code owner July 6, 2021 16:56
@codecov
Copy link
codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #810 (377e923) into main (934731c) will increase coverage by 0.11%.
The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   77.51%   77.62%   +0.11%     
==========================================
  Files         220      221       +1     
  Lines        6386     6391       +5     
==========================================
+ Hits         4950     4961      +11     
+ Misses       1196     1191       -5     
+ Partials      240      239       -1
Impacted Files Coverage Δ
pkg/remote/aws/init.go 0.00% <0.00%> (ø)
pkg/remote/aws/sns_topic_policy_details_fetcher.go 78.57% <78.57%> (ø)
pkg/remote/aws/sns_topic_policy_enumerator.go 100.00% <100.00%> (ø)

lotoussa
lotoussa previously approved these changes Jul 6, 2021
View reviewed changes
wbeuil
wbeuil previously approved these changes Jul 8, 2021
View reviewed changes
@wbeuil wbeuil linked an issue Jul 8, 2021 that may be closed by this pull request
Split sns_topic_policy_supplier #746
Closed
@moadibfr moadibfr dismissed stale reviews from wbeuil and lotoussa via 377e923 July 8, 2021 14:03
@moadibfr moadibfr force-pushed the fea/split_sns_topic_policy_supplier branch from 749064f to 377e923 Compare July 8, 2021 14:03
@wbeuil wbeuil merged commit 499870b into main Jul 8, 2021
@wbeuil wbeuil deleted the fea/split_sns_topic_policy_supplier branch July 8, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

@lotoussa lotoussa lotoussa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split sns_topic_policy_supplier
3 participants
@moadibfr @wbeuil @lotoussa
0