8000 split lambda_function_supplier by moadibfr · Pull Request #824 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

split lambda_function_supplier #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintain 8000 ers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

split lambda_function_supplier #824

merged 1 commit into from
Jul 9, 2021

Conversation

moadibfr
Copy link
Contributor
@moadibfr moadibfr commented Jul 8, 2021 •
edited by sundowndev
Loading

fixes #734

@moadibfr moadibfr requested a review from a team as a code owner July 8, 2021 17:14
@codecov
Copy link
codecov bot commented Jul 8, 2021 •
edited 8000
Loading

Codecov Report

Merging #824 (7414910) into main (ce479cd) will increase coverage by 0.09%.
The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
+ Coverage   78.47%   78.56%   +0.09%     
==========================================
  Files         223      224       +1     
  Lines        6369     6369              
==========================================
+ Hits         4998     5004       +6     
+ Misses       1143     1138       -5     
+ Partials      228      227       -1
Impacted Files Coverage Δ
pkg/remote/aws/init.go 0.00% <0.00%> (ø)
pkg/remote/aws/lambda_function_details_fetcher.go 78.57% <78.57%> (ø)
pkg/remote/aws/lambda_function_enumerator.go 100.00% <100.00%> (ø)

sundowndev
sundowndev suggested changes Jul 9, 2021
View reviewed changes
Copy link
Contributor
@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to rebase

@moadibfr moadibfr force-pushed the fea/split_lambda_function_supplier branch from 1b3c22a to 7414910 Compare July 9, 2021 09:08
@wbeuil wbeuil requested a review from sundowndev July 9, 2021 09:19
@wbeuil wbeuil merged commit 92dbd59 into main Jul 9, 2021
@wbeuil wbeuil deleted the fea/split_lambda_function_supplier branch July 9, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

@sundowndev sundowndev Awaiting requested review from sundowndev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split lambda_function_supplier
3 participants
@moadibfr @wbeuil @sundowndev
0