8000 Add `allocation_id` to `nat_gw` and `eip_assoc` by eliecharra · Pull Request #862 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add allocation_id to nat_gw and eip_assoc #862

New issue

Have a question abo 8000 ut this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2021
Merged

Add allocation_id to nat_gw and eip_assoc #862

merged 2 commits into from
Jul 20, 2021

Conversation

eliecharra
Copy link
Contributor
@eliecharra eliecharra commented Jul 20, 2021 •
edited
Loading

Fix #848

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Jul 20, 2021
@eliecharra eliecharra added this to the Deep Mode milestone Jul 20, 2021
@eliecharra eliecharra requested a review from a team July 20, 2021 15:52
@eliecharra eliecharra changed the title Add allocation_id to nat_gw and eip_assoc Add allocation_id to nat_gw and eip_assoc Jul 20, 2021
@codecov
Copy link
codecov bot commented Jul 20, 2021 •
edited
Loading

Codecov Report

Merging #862 (2a497b8) into main (bef2f77) will decrease coverage by 0.02%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   81.78%   81.75%   -0.03%     
==========================================
  Files         231      231              
  Lines        7421     7427       +6     
==========================================
+ Hits         6069     6072       +3     
- Misses       1133     1135       +2     
- Partials      219      220       +1
Impacted Files Coverage Δ
pkg/remote/aws/ec2_nat_gateway_enumerator.go 88.00% <40.00%> (-12.00%) ⬇️
pkg/remote/aws/ec2_eip_association_enumerator.go 100.00% <100.00%> (ø)
pkg/remote/aws/repository/ec2_repository.go 84.37% <100.00%> (ø)

@eliecharra eliecharra merged commit 751a836 into main Jul 20, 2021
@eliecharra eliecharra deleted the enrich_aws_nat_gw_eip_assoc branch July 20, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
Deep Mode
Development

Successfully merging this pull request may close these issues.

Minimal enrichment for "aws_nat_gateway_eip_assoc" middleware
2 participants
@eliecharra @sundowndev
0