8000 enrich internet gateway and route to use in default igw route middleware by moadibfr Β· Pull Request #863 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

enrich internet gateway and route to use in default igw route middleware #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

moadibfr
Copy link
Contributor
@moadibfr moadibfr commented Jul 21, 2021
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues Fix #844
❓ Documentation no

Description

enrich internet gateway and route to use in default igw route middleware

@codecov
Copy link
codecov bot commented Jul 21, 2021

Codecov Report

Merging #863 (617b094) into main (751a836) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   81.76%   81.74%   -0.02%     
==========================================
  Files         231      231              
  Lines        7430     7435       +5     
==========================================
+ Hits         6075     6078       +3     
- Misses       1135     1136       +1     
- Partials      220      221       +1     
Impacted Files Coverage Ξ”
pkg/remote/aws/ec2_internet_gateway_enumerator.go 91.66% <50.00%> (-8.34%) ⬇️
pkg/remote/aws/ec2_route_enumerator.go 100.00% <100.00%> (ΓΈ)

@moadibfr moadibfr self-assigned this Jul 21, 2021
@moadibfr moadibfr marked this pull request as ready for review July 21, 2021 10:05
@moadibfr moadibfr requested a review from a team as a code owner July 21, 2021 10:05
@eliecharra eliecharra merged commit dc6b9dc into main Jul 22, 2021
@eliecharra eliecharra deleted the fea/enrich_ig_route branch July 22, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimal enrichment for aws_default_igw_route middleware
4 participants
0