8000 Allow to build single binary in release mode by eliecharra · Pull Request #895 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow to build single binary in release mode #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2021
Merged

Allow to build single binary in release mode #895

merged 2 commits into from
Aug 4, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
🐛 Bug fix? no
🚀 New feature? no
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues Fix #894
❓ Documentation no

Description

Does not allow to specify a single os/arch to be built. It is a gorelease limitation, actually to achieve this you must comment unwanted os and arches in goreleaser config file

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Jul 27, 2021
@eliecharra eliecharra requested a review from sundowndev July 27, 2021 14:48
@eliecharra eliecharra requested a review from a team as a code owner July 27, 2021 14:48
@codecov
Copy link
codecov bot commented Jul 27, 2021 •
edited
Loading

Codecov Report

Merging #895 (4c2204f) into main (5465b6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   81.61%   81.61%           
=======================================
  Files         233      233           
  Lines        7609     7609           
=======================================
  Hits         6210     6210           
  Misses       1171     1171           
  Partials      228      228

sundowndev
sundowndev reviewed Jul 28, 2021
View reviewed changes
@eliecharra eliecharra force-pushed the build_script_improvement branch from d87561a to 683e27e Compare August 2, 2021 13:40
@eliecharra eliecharra requested a review from sundowndev August 4, 2021 12:47
moadibfr
moadibfr previously approved these changes Aug 4, 2021
View reviewed changes
sundowndev
sundowndev suggested changes Aug 4, 2021
View reviewed changes
Copy link
Contributor
@sundowndev sundowndev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally but ENV=release make build does not build for a single target as expected and make build fails because ENV is not defined

Dockerfile Outdated
COPY . .
RUN make release
RUN make build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ENV=release here

@eliecharra eliecharra force-pushed the build_script_improvement branch from 683e27e to 942da9d Compare August 4, 2021 13:28
@eliecharra eliecharra requested a review from sundowndev August 4, 2021 13:29
@sundowndev sundowndev merged commit 335d21a into main Aug 4, 2021
@sundowndev sundowndev deleted the build_script_improvement branch August 4, 2021 13:37
@sundowndev sundowndev mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

@moadibfr moadibfr moadibfr left review comments

Assignees
No one assigned
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow single os/arch build in build script
3 participants
@eliecharra @moadibfr @sundowndev
0