8000 Remove useless details fetchers by eliecharra · Pull Request #924 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove useless details fetchers #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2021
Merged

Remove useless details fetchers #924

merged 1 commit into from
Aug 10, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
🐛 Bug fix? no
🚀 New feature? no
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues Fix #915
❓ Documentation no

@eliecharra eliecharra added the kind/maintenance Refactoring or changes to the workspace label Aug 9, 2021
@eliecharra eliecharra requested a review from a team as a code owner August 9, 2021 15:16
@codecov
Copy link
codecov bot commented Aug 9, 2021

Codecov Report

Merging #924 (8bc135c) into main (8223beb) will increase coverage by 0.41%.
The diff coverage is 84.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   81.67%   82.09%   +0.41%     
==========================================
  Files         233      222      -11     
  Lines        7565     7332     -233     
==========================================
- Hits         6179     6019     -160     
+ Misses       1159     1118      -41     
+ Partials      227      195      -32
Impacted Files Coverage Δ
pkg/remote/aws/init.go 0.00% <0.00%> (ø)
pkg/resource/aws/aws_security_group_rule.go 59.59% <91.30%> (+9.59%) ⬆️
pkg/resource/aws/aws_default_route_table.go 100.00% <100.00%> (ø)
pkg/resource/aws/aws_dynamodb_table.go 100.00% <100.00%> (ø)
pkg/resource/aws/aws_iam_access_key.go 70.00% <100.00%> (+7.50%) ⬆️
pkg/resource/aws/aws_iam_role_policy_attachment.go 100.00% <100.00%> (ø)
pkg/resource/aws/aws_iam_user_policy_attachment.go 100.00% <100.00%> (ø)
pkg/resource/aws/aws_lambda_function.go 100.00% <100.00%> (ø)
pkg/resource/aws/aws_route.go 71.73% <100.00%> (+5.94%) ⬆️
pkg/resource/aws/aws_route_table_association.go 33.33% <100.00%> (+24.24%) ⬆️
... and 20 more

lotoussa
lotoussa approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor
@lotoussa lotoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eliecharra eliecharra merged commit 2f57501 into main Aug 10, 2021
@eliecharra eliecharra deleted the remove_useless_detail_fetcher branch August 10, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

@lotoussa lotoussa lotoussa approved these changes

Assignees
No one assigned
Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove custom details fetchers
3 participants
@eliecharra @sundowndev @lotoussa
0