8000 Display resource source in HTML output by sundowndev Β· Pull Request #931 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Display resource source in HTML output #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2021
Merged

Display resource source in HTML output #931

merged 3 commits into from
Aug 26, 2021

Conversation

sundowndev
Copy link
Contributor
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #876
❓ Documentation no

Description

This PR adds IaC source to drifts in HTML output.

@sundowndev sundowndev added the kind/enhancement New feature or improvement label Aug 19, 2021
@sundowndev sundowndev requested a review from a team as a code owner August 19, 2021 15:17
@sundowndev sundowndev force-pushed the feat/htmlDriftSource branch 3 times, most recently from ada9faf to a455519 Compare August 19, 2021 15:21
@codecov
Copy link
codecov bot commented Aug 19, 2021 •
edited
Loading

Codecov Report

Merging #931 (3d491aa) into main (bb65186) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
+ Coverage   82.29%   82.36%   +0.07%     
==========================================
  Files         222      222              
  Lines        7354     7373      +19     
==========================================
+ Hits         6052     6073      +21     
+ Misses       1112     1111       -1     
+ Partials      190      189       -1
Impacted Files Coverage Ξ”
pkg/cmd/scan/output/html.go 87.09% <100.00%> (+2.33%) ⬆️
pkg/resource/resource.go 80.74% <0.00%> (+1.24%) ⬆️

eliecharra
eliecharra suggested changes Aug 24, 2021
View reviewed changes
@sundowndev sundowndev force-pushed the feat/htmlDriftSource branch from a455519 to b6de4ed Compare August 24, 2021 13:01
@sundowndev sundowndev requested a review from eliecharra August 24, 2021 13:22
eliecharra
eliecharra suggested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor
@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only one last comment

@sundowndev sundowndev force-pushed the feat/htmlDriftSource branch from b6de4ed to c2fdc04 Compare August 24, 2021 13:30
eliecharra
eliecharra previously approved these changes Aug 24, 2021
View reviewed changes
@sundowndev sundowndev requested a review from a team August 24, 2021 13:57
wbeuil
wbeuil suggested changes Aug 25, 2021
View reviewed changes
@sundowndev sundowndev force-pushed the feat/htmlDriftSource branch from fdfeca4 to 7b7048f Compare August 25, 2021 12:50
wbeuil
wbeuil reviewed Aug 25, 2021
View reviewed changes
wbeuil
wbeuil previously approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor
@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundowndev sundowndev force-pushed the feat/htmlDriftSource branch from 21a7968 to 3d491aa Compare August 26, 2021 10:12
@sundowndev sundowndev merged commit abfa66c into main Aug 26, 2021
@sundowndev sundowndev deleted the feat/htmlDriftSource branch August 26, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

@eliecharra eliecharra eliecharra left review comments

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundowndev @eliecharra @wbeuil
0