8000 Display drifts in HTML output even when coverage is 100% by sundowndev Β· Pull Request #936 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Display drifts in HTML output even when coverage is 100% #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

sundowndev
Copy link
Contributor
Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #935
❓ Documentation no

display drifts even when coverage is 100
@sundowndev sundowndev added the kind/bug Something isn't working label Aug 24, 2021
@sundowndev sundowndev requested a review from a team as a code owner August 24, 2021 09:42
@codecov
Copy link
codecov bot commented Aug 24, 2021

Codecov Report

Merging #936 (16c889c) into main (d2339ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   82.27%   82.28%           
=======================================
  Files         222      222           
  Lines        7347     7348    +1     
=======================================
+ Hits         6045     6046    +1     
  Misses       1112     1112           
  Partials      190      190           
Impacted Files Coverage Ξ”
pkg/cmd/scan/output/html.go 84.76% <100.00%> (+0.14%) ⬆️

Copy link
Contributor
@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix πŸ‘πŸ»

@eliecharra eliecharra merged commit 5887ba0 into main Aug 24, 2021
@eliecharra eliecharra deleted the fix/htmlOutputCoverage branch August 24, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0