8000 Add support for `azurerm_storage_account` and `azurerm_storage_container` by eliecharra Β· Pull Request #938 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for azurerm_storage_account and azurerm_storage_container #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2021
Merged

Add support for azurerm_storage_account and azurerm_storage_container #938

merged 1 commit into from
Sep 8, 2021

Conversation

eliecharra
Copy link
Contributor
@eliecharra eliecharra commented Aug 25, 2021 •
edited
Loading
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #903
❓ Documentation snyk/driftctl-docs#94

@codecov
Copy link
codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #938 (74b9394) into main (937eeb4) will decrease coverage by 0.37%.
The diff coverage is 52.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   82.01%   81.64%   -0.38%     
==========================================
  Files         230      236       +6     
  Lines        7601     7740     +139     
==========================================
+ Hits         6234     6319      +85     
- Misses       1169     1225      +56     
+ Partials      198      196       -2
Impacted Files Coverage Ξ”
pkg/remote/azurerm/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/azurerm/provider.go 0.00% <0.00%> (ΓΈ)
pkg/remote/remote.go 36.84% <0.00%> (-4.34%) ⬇️
pkg/remote/terraform/provider.go 6.66% <0.00%> (-0.06%) ⬇️
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
pkg/terraform/providers.go 53.33% <ΓΈ> (ΓΈ)
pkg/remote/azurerm/repository/storage.go 83.78% <83.78%> (ΓΈ)
...mote/azurerm/azurerm_storage_account_enumerator.go 100.00% <100.00%> (ΓΈ)
...te/azurerm/azurerm_storage_container_enumerator.go 100.00% <100.00%> (ΓΈ)
pkg/resource/azurerm/metadata.go 100.00% <100.00%> (ΓΈ)
... and 7 more

@eliecharra eliecharra force-pushed the add_azurerm_provider branch 3 times, most recently from 59fa463 to 00df37e Compare August 27, 2021 09:38
@eliecharra eliecharra marked this pull request as ready for review August 27, 2021 13:06
@eliecharra eliecharra requested a review from a team as a code owner August 27, 2021 13:06
@eliecharra eliecharra added the kind/enhancement New feature or improvement label Aug 27, 2021
@eliecharra eliecharra force-pushed the add_azurerm_provider branch from 00df37e to a5cb845 Compare August 30, 2021 13:20
sundowndev
sundowndev suggested changes Aug 30, 2021
View reviewed changes
@eliecharra eliecharra force-pushed the add_azurerm_provider branch from a5cb845 to cf54619 Compare August 31, 2021 10:31
wbeuil
wbeuil suggested changes Sep 2, 2021
View reviewed changes
Copy link
Contributor
@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double-check the wording on the init.go file to match the ones in the dev docs please, I found typos in it.

pkg/remote/azurerm_storage_scanner_test.go Outdated
wantErr: error2.NewResourceListingError(dummyError, resourceazure.AzureStorageContainerResourceType),
},
{
test: "multiples storage containers",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliecharra still miss this one and I'm good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops sorry

@eliecharra
Copy link
Contributor Author

Can you double-check the wording on the init.go file to match the ones in the dev docs please, I found typos in it.

I removed all the old comment from my copy paste from the init.go from the dev doc

sundowndev
sundowndev previously approved these changes Sep 8, 2021
View reviewed changes
wbeuil
wbeuil approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor
@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good job as always :)

@eliecharra eliecharra merged commit 3459a17 into main Sep 8, 2021
@eliecharra eliecharra deleted the add_azurerm_provider branch September 8, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

@sundowndev sundowndev sundowndev left review comments

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliecharra @wbeuil @sundowndev
0