8000 Add aws_api_gateway_rest_api resource by wbeuil Β· Pull Request #1026 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add aws_api_gateway_rest_api resource #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

Add aws_api_gateway_rest_api resource #1026

merged 1 commit into from
Sep 16, 2021

Conversation

wbeuil
Copy link
Contributor
@wbeuil wbeuil commented Sep 14, 2021
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #960
❓ Documentation yes

Description

New resource aws_api_gateway_rest_api

@wbeuil wbeuil requested a review from a team as a code owner September 14, 2021 14:55
@codecov
Copy link
codecov bot commented Sep 14, 2021 •
edited
Loading

Codecov Report

Merging #1026 (71aa38e) into main (ce80b1d) will decrease coverage by 0.00%.
The diff coverage is 80.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
- Coverage   81.49%   81.48%   -0.01%     
==========================================
  Files         245      247       +2     
  Lines        7932     7973      +41     
==========================================
+ Hits         6464     6497      +33     
- Misses       1267     1274       +7     
- Partials      201      202       +1
Impacted Files Coverage Ξ”
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
...kg/remote/aws/repository/api_gateway_repository.go 66.66% <66.66%> (ΓΈ)
pkg/remote/aws/api_gateway_rest_api_enumerator.go 100.00% <100.00%> (ΓΈ)

@wbeuil wbeuil mentioned this pull request Sep 14, 2021
Merged
sundowndev
sundowndev suggested changes Sep 15, 2021
View reviewed changes
Copy link
Contributor
@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, I just left few comments about testing

sundowndev
sundowndev previously approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor
@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ»

@eliecharra eliecharra merged commit 1012f69 into main Sep 16, 2021
@eliecharra eliecharra deleted the res/api_gtw branch September 16, 2021 14:00
@sundowndev sundowndev added the kind/enhancement New feature or improvement label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbeuil @sundowndev @eliecharra
0