8000 Add azurerm virtual network by eliecharra Β· Pull Request #1082 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add azurerm virtual network #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2021
Merged

Add azurerm virtual network #1082

merged 2 commits into from
Oct 1, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #1037
❓ Documentation snyk/driftctl-docs#124

@eliecharra eliecharra requested a review from a team as a code owner September 29, 2021 12:47
@eliecharra eliecharra force-pushed the add_azurerm_virtual_network branch from 348b408 to df75e41 Compare September 29, 2021 12:48
@eliecharra eliecharra added the kind/enhancement New feature or improvement label Sep 29, 2021
@codecov
Copy link
codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #1082 (0249fed) into main (7f1601e) will decrease coverage by 0.00%.
The diff coverage is 81.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.01%     
==========================================
  Files         275      277       +2     
  Lines        8575     8618      +43     
==========================================
+ Hits         7041     7076      +35     
- Misses       1322     1330       +8     
  Partials      212      212
Impacted Files Coverage Ξ”
pkg/remote/azurerm/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/azurerm/repository/storage.go 68.88% <ΓΈ> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
pkg/remote/azurerm/repository/network.go 70.00% <70.00%> (ΓΈ)
...mote/azurerm/azurerm_virtual_network_enumerator.go 100.00% <100.00%> (ΓΈ)

sundowndev
sundowndev approved these changes Sep 29, 2021
View reviewed changes
sundowndev
sundowndev suggested changes Sep 29, 2021
View reviewed changes
Copy link
Contributor
@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*approved by mistake

@eliecharra eliecharra force-pushed the add_azurerm_virtual_network branch from df75e41 to 1fa17d2 Compare October 1, 2021 08:43
@eliecharra eliecharra requested a review from sundowndev October 1, 2021 08:43
sundowndev
sundowndev approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor
@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ»

@eliecharra eliecharra merged commit d4de6a0 into main Oct 1, 2021
@eliecharra eliecharra deleted the add_azurerm_virtual_network branch October 1, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees

@sundowndev sundowndev

Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @sundowndev
0