8000 Add storage bucket iam members and policies by moadibfr Β· Pull Request #1083 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add storage bucket iam members and policies #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 7, 2021
Merged

Add storage bucket iam members and policies #1083

merged 5 commits into from
Oct 7, 2021

Conversation

moadibfr
Copy link
Contributor
@moadibfr moadibfr commented Sep 30, 2021 •
edited by sundowndev
Loading
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #1065
❓ Documentation yes

Description

Add storage bucket iam members and policies

@moadibfr moadibfr requested a review from a team as a code owner September 30, 2021 08:03
@moadibfr moadibfr force-pushed the fea/google_storage_bucket_iam_members branch from e833dcb to 552614b Compare October 1, 2021 15:12
@codecov
Copy link
codecov bot commented Oct 1, 2021 •
edited
Loading

Codecov Report

Merging #1083 (0949440) into main (67513ac) will increase coverage by 0.04%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
+ Coverage   81.26%   81.30%   +0.04%     
==========================================
  Files         305      307       +2     
  Lines       11136    11225      +89     
==========================================
+ Hits         9050     9127      +77     
- Misses       1858     1868      +10     
- Partials      228      230       +2
Impacted Files Coverage Ξ”
pkg/remote/google/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
...esource/google/google_storage_bucket_iam_member.go 28.57% <28.57%> (ΓΈ)
...es/google_storage_bucket_iam_policy_transformer.go 92.68% <92.68%> (ΓΈ)
pkg/driftctl.go 72.50% <100.00%> (+0.94%) ⬆️
pkg/middlewares/google_legacy_bucket_iam_member.go 100.00% <100.00%> (ΓΈ)
...s/google_storage_bucket_iam_binding_transformer.go 100.00% <100.00%> (ΓΈ)
...gle/google_storage_bucket_iam_member_enumerator.go 92.10% <100.00%> (ΓΈ)
pkg/resource/google/metadatas.go 100.00% <100.00%> (ΓΈ)

@moadibfr moadibfr marked this pull request as draft October 4, 2021 08:40
@moadibfr moadibfr force-pushed the fea/google_storage_bucket_iam_members branch from 552614b to f06c405 Compare October 4, 2021 17:07
@moadibfr moadibfr marked this pull request as ready for review October 4, 2021 17:07
eliecharra
eliecharra suggested changes Oct 6, 2021
View reviewed changes
@moadibfr moadibfr force-pushed the fea/google_storage_bucket_iam_members branch from f06c405 to c5978ec Compare October 6, 2021 15:04
@moadibfr moadibfr requested a review from eliecharra October 7, 2021 08:03
@eliecharra eliecharra merged commit 0e27cd8 into main Oct 7, 2021
@eliecharra eliecharra deleted the fea/google_storage_bucket_iam_members branch October 7, 2021 12:57
@sundowndev sundowndev added the kind/enhancement New feature or improvement label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moadibfr @eliecharra @sundowndev
0