8000 Add azurerm_firewall by eliecharra · Pull Request #1099 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add azurerm_firewall #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2021
Merged

Add azurerm_firewall #1099

merged 2 commits into from
Oct 7, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
🐛 Bug fix? no
🚀 New feature? yes
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues #1040
❓ Documentation snyk/driftctl-docs#137

@eliecharra eliecharra requested a review from a team as a code owner October 7, 2021 09:19
@codecov
8000
Copy link
codecov bot commented Oct 7, 2021 •
edited
Loading

Codecov Report

Merging #1099 (6d0e5af) into main (4b43c74) will increase coverage by 0.00%.
The diff coverage is 81.96%.

❗ Current head 6d0e5af differs from pull request most recent head 01639e1. Consider uploading reports for the commit 01639e1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files         303      305    +2     
  Lines       11075    11136   +61     
=======================================
+ Hits         9000     9050   +50     
- Misses       1848     1858   +10     
- Partials      227      228    +1
Impacted Files Coverage Δ
pkg/remote/azurerm/init.go 0.00% <0.00%> (ø)
pkg/resource/resource_types.go 100.00% <ø> (ø)
pkg/resource/azurerm/azurerm_firewall.go 12.50% <12.50%> (ø)
pkg/remote/azurerm/repository/network.go 83.83% <87.50%> (+1.17%) ⬆️
pkg/remote/azurerm/azurerm_firewalls_enumerator.go 100.00% <100.00%> (ø)
pkg/resource/azurerm/metadata.go 100.00% <100.00%> (ø)

@eliecharra eliecharra merged commit 67513ac into main Oct 7, 2021
@eliecharra eliecharra deleted the add_azurerm_firewall branch October 7, 2021 12:16
@sundowndev sundowndev added the kind/enhancement New feature or improvement label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @sundowndev
0