8000 Add aws_api_gateway_rest_api_policy resource by wbeuil Β· Pull Request #1123 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add aws_api_gateway_rest_api_policy resource #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add aws_api_gateway_rest_api_policy resource #1123

merged 1 commit into from
Oct 19, 2021

Conversation

wbeuil
Copy link
Contributor
@wbeuil wbeuil commented Oct 11, 2021 •
edited by sundowndev
Loading
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #1117
❓ Documentation snyk/driftctl-docs#146

Description

Need to first merge #1120 before this one

@codecov
Copy link
codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #1123 (08e29d8) into main (91145d8) will increase coverage by 0.08%.
The diff coverage is 95.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
+ Coverage   81.48%   81.57%   +0.08%     
==========================================
  Files         323      325       +2     
  Lines       11822    11900      +78     
==========================================
+ Hits         9633     9707      +74     
- Misses       1947     1950       +3     
- Partials      242      243       +1
Impacted Files Coverage Ξ”
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
...ewares/aws_api_gateway_rest_api_policy_expander.go 93.87% <93.87%> (ΓΈ)
pkg/driftctl.go 72.95% <100.00%> (+0.22%) ⬆️
...mote/aws/api_gateway_rest_api_policy_enumerator.go 100.00% <100.00%> (ΓΈ)

@wbeuil wbeuil force-pushed the res/api_gtw_rest_api_policy branch 2 times, most recently from 9b30250 to 9e18de7 Compare October 12, 2021 09:49
@wbeuil wbeuil marked this pull request as ready for review October 12, 2021 09:49
@wbeuil wbeuil requested a review from a team as a code owner October 12, 2021 09:49
@wbeuil wbeuil added kind/enhancement New feature or improvement and removed kind/blocked labels Oct 12, 2021
@wbeuil wbeuil force-pushed the res/api_gtw_rest_api_policy branch 2 times, most recently from 5e2b3f0 to d989458 Compare October 15, 2021 14:11
wbeuil
wbeuil commented Oct 15, 2021
View reviewed changes
@wbeuil wbeuil force-pushed the res/api_gtw_rest_api_policy branch from d989458 to b5a2601 Compare October 15, 2021 14:19
eliecharra
eliecharra previously approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor
@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work πŸŽ‰

@eliecharra
Copy link
Contributor

Need a rebase here @wbeuil

@wbeuil wbeuil force-pushed the res/api_gtw_rest_api_policy branch from b5a2601 to 08e29d8 Compare October 18, 2021 14:25
@eliecharra eliecharra self-assigned this Oct 19, 2021
@eliecharra eliecharra merged commit 7b84f9c into main Oct 19, 2021
@eliecharra eliecharra deleted the res/api_gtw_rest_api_policy branch October 19, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra left review comments

Assignees

@eliecharra eliecharra

Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbeuil @eliecharra
0