8000 Add google_bigquery_dataset by eliecharra · Pull Request #1145 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add google_bigquery_dataset #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2021
Merged

Add google_bigquery_dataset #1145

merged 2 commits into from
Oct 19, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
🐛 Bug fix? no
🚀 New feature? yes
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues #978
❓ Documentation https://github.com/cloudskiff/driftctl-docs/pull/156/files

@eliecharra eliecharra requested a review from a team as a code owner October 19, 2021 13:14
@codecov
Copy link
codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #1145 (70d0d0e) into main (e6b3b12) will increase coverage by 0.00%.
The diff coverage is 82.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1145   +/-   ##
=======================================
  Coverage   81.70%   81.70%           
=======================================
  Files         327      329    +2     
  Lines       11965    12005   +40     
=======================================
+ Hits         9776     9809   +33     
- Misses       1941     1947    +6     
- Partials      248      249    +1
Impacted Files Coverage Δ
pkg/remote/google/init.go 0.00% <0.00%> (ø)
pkg/resource/resource_types.go 100.00% <ø> (ø)
pkg/resource/google/google_bigquery_dataset.go 16.66% <16.66%> (ø)
...emote/google/google_bigquery_dataset_enumerator.go 100.00% <100.00%> (ø)
pkg/remote/google/repository/asset.go 100.00% <100.00%> (ø)
pkg/resource/google/metadatas.go 100.00% <100.00%> (ø)

@eliecharra eliecharra force-pushed the add_google_bigquery_dataset branch from 6ede3c3 to 9d91238 Compare October 19, 2021 13:44
@eliecharra eliecharra merged commit 7c653d0 into main Oct 19, 2021
@eliecharra eliecharra deleted the add_google_bigquery_dataset branch October 19, 2021 15:20
@sundowndev sundowndev added the kind/enhancement New feature or improvement label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @sundowndev
0