8000 Add google_compute_address by eliecharra Β· Pull Request #1143 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add google_compute_address #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

Add google_compute_address #1143

merged 1 commit into from
Oct 21, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #986
❓ Documentation snyk/driftctl-docs#155

@eliecharra eliecharra requested a review from a team as a code owner October 19, 2021 09:54
@eliecharra eliecharra added the kind/enhancement New feature or improvement label Oct 19, 2021
@codecov
Copy link
8000
codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #1143 (4295f68) into main (d60ba9f) will increase coverage by 0.00%.
The diff coverage is 82.22%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1143   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         335      337    +2     
  Lines       12185    12230   +45     
=======================================
+ Hits         9908     9945   +37     
- Misses       2026     2033    +7     
- Partials      251      252    +1
Impacted Files Coverage Ξ”
pkg/remote/google/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
pkg/resource/google/google_compute_address.go 14.28% <14.28%> (ΓΈ)
...remote/google/google_compute_address_enumerator.go 100.00% <100.00%> (ΓΈ)
pkg/remote/google/repository/asset.go 100.00% <100.00%> (ΓΈ)
pkg/resource/google/metadatas.go 100.00% <100.00%> (ΓΈ)

@eliecharra eliecharra force-pushed the add_google_compute_address branch from 75f8a73 to 18be71a Compare October 19, 2021 12:30
sundowndev
sundowndev reviewed Oct 20, 2021
View reviewed changes
@eliecharra eliecharra force-pushed the add_google_compute_address branch 2 times, most recently from 2001b9d to 7c29ee3 Compare October 21, 2021 13:44
@eliecharra eliecharra requested a review from sundowndev October 21, 2021 13:44
@eliecharra eliecharra force-pushed the add_google_compute_address branch from 7c29ee3 to da1d18e Compare October 21, 2021 13:46
sundowndev
sundowndev reviewed Oct 21, 2021
View reviewed changes
@eliecharra eliecharra force-pushed the add_google_compute_address branch from da1d18e to 4295f68 Compare October 21, 2021 14:09
@eliecharra eliecharra requested a review from sundowndev October 21, 2021 14:09
sundowndev
sundowndev approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor
@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰

@eliecharra eliecharra merged commit 97a4c29 into main Oct 21, 2021
@eliecharra eliecharra deleted the add_google_compute_address branch October 21, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @sundowndev
0