8000 Add google_cloudfunctions_function by eliecharra Β· Pull Request #1156 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add google_cloudfunctions_function #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

Add google_cloudfunctions_function #1156

merged 1 commit into from
Oct 22, 2021

Conversation

eliecharra
Copy link
Contributor
@eliecharra eliecharra commented Oct 21, 2021 •
edited
Loading
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #982
❓ Documentation snyk/driftctl-docs#160

⚠️ ⚠️ @cloudskiff/engineering Please pay attention to:

@eliecharra eliecharra requested a review from a team as a code owner October 21, 2021 13:21
@eliecharra< 8000 /a> eliecharra force-pushed the add_google_cloudfunctions_function branch from b34f0bb to db476ac Compare October 21, 2021 13:22
@codecov
Copy link
codecov bot commented Oct 21, 2021 •
edited
Loading

Codecov Report

Merging #1156 (cb2b2fb) into main (86b5e27) will increase coverage by 0.06%.
The diff coverage is 93.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
+ Coverage   81.31%   81.38%   +0.06%     
==========================================
  Files         339      340       +1     
  Lines       12336    12401      +65     
==========================================
+ Hits        10031    10092      +61     
- Misses       2050     2053       +3     
- Partials      255      256       +1
Impacted Files Coverage Ξ”
pkg/remote/google/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
pkg/remote/google/repository/asset.go 97.05% <91.42%> (-2.95%) ⬇️
...oogle/google_cloudfunctions_function_enumerator.go 100.00% <100.00%> (ΓΈ)

@eliecharra eliecharra force-pushed the add_google_cloudfunctions_function branch from db476ac to e2e3fdd Compare October 22, 2021 09:17
sundowndev
sundowndev reviewed Oct 22, 2021
View reviewed changes
@eliecharra eliecharra force-pushed the add_google_cloudfunctions_function branch from e2e3fdd to 9bfe1e8 Compare October 22, 2021 09:40
@eliecharra eliecharra requested a review from sundowndev October 22, 2021 09:40
@eliecharra eliecharra force-pushed the add_google_cloudfunctions_function branch from 9bfe1e8 to cb2b2fb Compare October 22, 2021 11:44
@eliecharra eliecharra requested a review from a team October 22, 2021 11:44
@eliecharra eliecharra merged commit f5ff881 into main Oct 22, 2021
@eliecharra eliecharra deleted the add_google_cloudfunctions_function branch October 22, 2021 12:13
@sundowndev sundowndev added the kind/enhancement New feature or improvement label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @sundowndev
0