8000 add support for azurerm_private_dns_zone by moadibfr Β· Pull Request #1152 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add support for azurerm_private_dns_zone #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

add support for azurerm_private_dns_zone #1152

merged 1 commit into from
Oct 25, 2021

Conversation

moadibfr
Copy link
Contributor
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #1063
❓ Documentation yes

@moadibfr moadibfr requested a review from a team as a code owner October 20, 2021 14:48
eliecharra
eliecharra suggested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor
@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ .terraform.lock.hcl is empty

@eliecharra eliecharra self-assigned this Oct 21, 2021
@moadibfr moadibfr force-pushed the fea/azurm_privatedns_zone branch from 5a4d059 to c8b5413 Compare October 22, 2021 15:38
@codecov
Copy link
codecov bot commented Oct 22, 2021 •
edited
Loading

Codecov Report

Merging #1152 (4ad4b76) into main (35e2b48) will decrease coverage by 0.00%.
The diff coverage is 79.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   81.55%   81.54%   -0.01%     
==========================================
  Files         345      348       +3     
  Lines       12608    12672      +64     
==========================================
+ Hits        10283    10334      +51     
- Misses       2067     2079      +12     
- Partials      258      259       +1
Impacted Files Coverage Ξ”
pkg/remote/azurerm/init.go 0.00% <0.00%> (ΓΈ)
pkg/resource/resource_types.go 100.00% <ΓΈ> (ΓΈ)
pkg/remote/azurerm/repository/privatedns.go 61.53% <61.53%> (ΓΈ)
...mote/azurerm/azurerm_privatedns_zone_enumerator.go 100.00% <100.00%> (ΓΈ)
pkg/resource/azurerm/azurerm_private_dns_zone.go 100.00% <100.00%> (ΓΈ)
pkg/resource/azurerm/metadata.go 100.00% <100.00%> (ΓΈ)

@moadibfr moadibfr requested a review from eliecharra October 22, 2021 16:22
eliecharra
eliecharra previously approved these changes Oct 25, 2021
View reviewed changes
@eliecharra
Copy link
Contributor

@moadibfr Can you add a doc PR too to get this one merged πŸ™πŸ»
8000

@moadibfr moadibfr force-pushed the fea/azurm_privatedns_zone branch from c8b5413 to 3ce5dee Compare October 25, 2021 09:19
@moadibfr
Copy link
Contributor Author

@moadibfr Can you add a doc PR too to get this one merged πŸ™πŸ»

snyk/driftctl-docs#166

eliecharra
eliecharra suggested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor
@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a test to metadata_test.go

@moadibfr moadibfr force-pushed the fea/azurm_privatedns_zone branch from 3ce5dee to 4ad4b76 Compare October 25, 2021 12:05
@moadibfr moadibfr requested a review from eliecharra October 25, 2021 12:09
@eliecharra eliecharra merged commit a271c9b into main Oct 25, 2021
@eliecharra eliecharra deleted the fea/azurm_privatedns_zone branch October 25, 2021 12:20
@sundowndev sundowndev added the kind/enhancement New feature or improvement label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

Assignees

@eliecharra eliecharra

Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moadibfr @eliecharra @sundowndev
0