Implement glob support for enumerators #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.8 #353 +/- ##
==========================================
- Coverage 70.98% 70.96% -0.02%
==========================================
Files 288 289 +1
Lines 6545 6562 +17
==========================================
+ Hits 4646 4657 +11
- Misses 1522 1525 +3
- Partials 377 380 +3
|
5e6688d to
33033f7
Compare
33033f7 to
0500da0
Compare
sundowndev
suggested changes
Mar 22, 2021
22918a3 to
c2a8d2a
Compare
c2a8d2a to
7bd3591
Compare
7bd3591 to
f25792e
Compare
|
user mwarkentin on discord had multiple files on the same s3 bucket were his statefile lays and listing take too much time. Progress bar is being stopped. |
|
To rebase on |
Support go glob syntax + ** syntaxe on file enumerator Support go glob syntax on s3 enumerator
f25792e to
5141f1e
Compare
wbeuil
previously requested changes
Apr 30, 2021
| return nil, err | ||
| } | ||
|
|
||
| // filpath match does not compile so we try to match to be able to report the pattern error |
There was a problem hiding this comment.
filepath match .... so we use the match method to report the pattern error
5 tasks
3e9e07e to
2136c8b
Compare
2136c8b to
7838728
Compare
moadibfr
commented
May 7, 2021
eliecharra
previously approved these changes
May 7, 2021
eliecharra
previously approved these changes
May 7, 2021
moadibfr
commented
May 7, 2021
| info, err := os.Lstat(path) | ||
| if err != nil { | ||
| if isGlob := strings.Contains(path, "*"); !isGlob && err != nil { |
There was a problem hiding this comment.
why don't you use HasMeta?
845ca11 to
144ccd4
Compare
eliecharra
approved these changes
May 7, 2021
This was referenced May 7, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limited glob support.
Support go glob syntax + ** syntax on file enumerator
Support go glob syntax on s3 enumerator