8000 seperate ark/spring shutdown by HzjNeverStop · Pull Request #817 · sofastack/sofa-boot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

seperate ark/spring shutdown #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2021
Merged

seperate ark/spring shutdown #817

merged 5 commits into from
Apr 21, 2021

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link
codecov bot commented Apr 14, 2021 •
edited
Loading

Codecov Report

Merging #817 (5a9e95c) into master (bc31b1d) will decrease coverage by 0.21%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #817      +/-   ##
============================================
- Coverage     71.33%   71.11%   -0.22%     
  Complexity       32       32              
============================================
  Files           297      297              
  Lines          8382     8399      +17     
  Branches       1160     1162       +2     
============================================
- Hits           5979     5973       -6     
- Misses         1727     1750      +23     
  Partials        676      676
Impacted Files Coverage Δ Complexity Δ
...onfigure/runtime/SofaRuntimeAutoConfiguration.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...time/spring/aware/DefaultRuntimeShutdownAware.java 0.00% <ø> (-62.50%) 0.00 <0.00> (ø)
...ime/component/impl/StandardSofaRuntimeManager.java 70.90% <66.66%> (-4.57%) 0.00 <0.00> (ø)
...a/runtime/component/impl/ComponentManagerImpl.java 60.18% <71.42%> (-0.02%) 0.00 <0.00> (ø)
...ay/sofa/runtime/spring/SpringContextComponent.java 72.22% <83.33%> (+5.55%) 0.00 <0.00> (ø)
...pay/sofa/runtime/SofaBizUninstallEventHandler.java 64.28% <100.00%> (ø) 0.00 <0.00> (ø)
...runtime/ext/component/ExtensionPointComponent.java 51.51% <0.00%> (-30.31%) 0.00% <0.00%> (ø%)
...ipay/sofa/runtime/api/ServiceRuntimeException.java 0.00% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...sofa/runtime/ext/component/ExtensionComponent.java 54.38% <0.00%> (-1.76%) 0.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ecfc66...5a9e95c. Read the comment docs.

alaneuler
alaneuler reviewed Apr 16, 2021
View reviewed changes
...ime-sofa-boot/src/main/java/com/alipay/sofa/runtime/component/impl/ComponentManagerImpl.java
< 8000 td data-line-number="91" class="blob-num blob-num-addition">
@@ -86,7 +88,23 @@ public int size() {
@Override
public void shutdown() {
List<ComponentInfo> elems = new ArrayList<>(registry.values());
// shutdown spring contexts first
Copy link
Contributor
@alaneuler alaneuler Apr 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should shutdown spring context after other component unregistering because e.g., ServiceComponents are beans ultimately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@alaneuler
Copy link
Contributor
alaneuler commented Apr 16, 2021 •
edited
Loading

plz fire an issue and refer to it

@alaneuler
Copy link
Contributor
alaneuler commented Apr 16, 2021 •
edited
Loading

don't delete DefaultRuntimeShutdownAware directly, annotate it with @deprecated and scheduled to remove in 3.9.0

@HzjNeverStop HzjNeverStop linked an issue Apr 16, 2021 that may be closed by this pull request
SofaRuntimeMananger need to close components when root context close #818
Closed
alaneuler
alaneuler approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor
@alaneuler alaneuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit bd5867e into sofastack:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaneuler alaneuler alaneuler approved these changes

Assignees
No one assigned
Labels
cla:yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SofaRuntimeMananger need to close components when root context close
2 participants
@HzjNeverStop @alaneuler
0