8000 Fix tracer bean name conflicting with spring cloud by alaneuler · Pull Request #830 · sofastack/sofa-boot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix tracer bean name conflicting with spring cloud #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

Fix tracer bean name conflicting with spring cloud #830

merged 1 commit into from
May 28, 2021

Conversation

alaneuler
Copy link
Contributor

No description provided.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/XS labels May 14, 2021
@codecov
Copy link
codecov bot commented May 14, 2021

Codecov Report

Merging #830 (8de7cec) into master (fcad392) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #830      +/-   ##
============================================
- Coverage     71.43%   71.29%   -0.15%     
  Complexity       36       36              
============================================
  Files           298      298              
  Lines          8465     8465              
  Branches       1171     1171              
============================================
- Hits           6047     6035      -12     
- Misses         1735     1746      +11     
- Partials        683      684       +1
Impacted Files Coverage Δ Complexity Δ
...oconfigure/tracer/SofaTracerAutoConfiguration.java 90.90% <ø> (ø) 0.00 <0.00> (ø)
...ay/sofa/runtime/spring/SpringContextComponent.java 44.44% <0.00%> (-27.78%) 0.00% <0.00%> (ø%)
...fa/runtime/spring/SpringContextImplementation.java 25.00% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...a/runtime/component/impl/ComponentManagerImpl.java 54.62% <0.00%> (-5.56%) 0.00% <0.00%> (ø%)
...m/alipay/sofa/isle/stage/ModuleLogOutputStage.java 92.40% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcad392...8de7cec. Read the comment docs.

HzjNeverStop
HzjNeverStop approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor
@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HzjNeverStop merged commit 1761696 into sofastack:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HzjNeverStop HzjNeverStop HzjNeverStop approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alaneuler @HzjNeverStop
0