8000 Fix some typos in code and comments by debug-zhang · Pull Request #895 · sofastack/sofa-boot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix some typos in code and comments #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2021
Merged

Fix some typos in code and comments #895

merged 1 commit into from
Dec 23, 2021

Conversation

debug-zhang
Copy link
Contributor

No description provided.

@debug-zhang
fix typo
9ae270a 
Signed-off-by: debug-zhang <zh.xinze@gmail.com>
@sofastack-bot
Copy link
sofastack-bot bot commented Dec 12, 2021

Hi @debug-zhang, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@debug-zhang debug-zhang reopened this Dec 12, 2021
@sofastack-bot
Copy link
sofastack-bot bot commented Dec 12, 2021

Hi @debug-zhang, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@codecov
Copy link
codecov bot commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #895 (9ae270a) into master (3d82c96) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #895   +/-   ##
=========================================
  Coverage     71.21%   71.21%           
  Complexity       36       36           
=========================================
  Files           303      303           
  Lines          8627     8627           
  Branches       1201     1201           
=========================================
  Hits           6144     6144           
  Misses         1792     1792           
  Partials        691      691
Impacted Files Coverage Δ
...lipay/sofa/healthcheck/ReadinessCheckListener.java 88.80% <ø> (ø)
...om/alipay/sofa/isle/deployment/DependencyTree.java 52.23% <ø> (ø)
...isle/deployment/impl/FileDeploymentDescriptor.java 70.37% <ø> (ø)
...y/sofa/isle/spring/SofaModuleContextLifecycle.java 66.66% <ø> (ø)
...lipay/sofa/rpc/boot/common/NetworkAddressUtil.java 50.00% <ø> (ø)
...va/com/alipay/sofa/common/xmap/XAnnotatedList.java 46.73% <ø> (ø)
.../common/xmap/annotation/spring/XMapSpringUtil.java 40.00% <ø> (ø)
.../sofa/runtime/api/client/param/ExtensionParam.java 100.00% <ø> (ø)
...ommon/xmap/annotation/spring/XAnnotatedSpring.java 63.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d82c96...9ae270a. Read the comment docs.

HzjNeverStop
HzjNeverStop approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor
@HzjNeverStop HzjNeverStop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit ebd62d5 into sofastack:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HzjNeverStop HzjNeverStop HzjNeverStop approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cla:no First-time contributor size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debug-zhang @HzjNeverStop
0