8000 Parameter xsd and annotation by ScienJus · Pull Request #330 · sofastack/sofa-boot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Parameter xsd and annotation #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2019
Merged

Parameter xsd and annotation #330

merged 4 commits into from
Jan 9, 2019

Conversation

ScienJus
Copy link
Member
@ScienJus ScienJus commented Jan 3, 2019

@ScienJus ScienJus force-pushed the parameter-xsd-and-annotation branch from f01c387 to d920eb0 Compare January 7, 2019 02:47
@straybirdzls straybirdzls added this to the 2.6.0 milestone Jan 8, 2019
@straybirdzls
Copy link
Member
straybirdzls commented Jan 9, 2019 •
edited
Loading

@ScienJus hello, can you add some cases for the xsd change, currently we do not have xsd cases in this project, but we write some cases in internal projects, an example is as below:

@Test
public void test() throws Exception {
        loadXml("XX.xml");
}

private void loadXml(String xml) throws Exception {
        DocumentLoader documentLoader = new DefaultDocumentLoader();
        documentLoader.loadDocument(new InputSource(this.getClass().getClassLoader()
            .getResourceAsStream(xml)), new DelegatingEntityResolver(this.getClass()
            .getClassLoader()), new DefaultErrorHandler(),
            XmlValidationModeDetector.VALIDATION_XSD, true);
    }

Keep us noticed no matter whether you are convenient or not 😊.

@ScienJus ScienJus force-pushed the parameter-xsd-and-annotation branch from d920eb0 to 2afc57e Compare January 9, 2019 03:42
@ScienJus
Copy link
Member Author
ScienJus commented Jan 9, 2019

@straybirdzls just added a sample, please take a look.

Do you need more cases? (such as a failed case?)

@straybirdzls
Copy link
Member

@ScienJus great👍 I think one failed case will be better and enough，eg: sofa:parameter with no key or no value.

@ScienJus
Copy link
Member Author
ScienJus commented Jan 9, 2019

@straybirdzls done.

Note: when this PR is merged, we need to upgrade the sofa-boot version in the sofa-rpc-boot-projects to implement the part of sofa-rpc-boot-projects.

Sorry, something went wrong.

@QilongZhang QilongZhang merged commit 50a8af7 into sofastack:2.x Jan 9, 2019
@QilongZhang
Copy link
Contributor

@straybirdzls done.

Note: when this PR is merged, we need to upgrade the sofa-boot version in the sofa-rpc-boot-projects to implement the part of sofa-rpc-boot-projects.

I have deployed 2.6.0-SNAPSHOT to maven snapshot repo, you can continue your work. thx.

QilongZhang pushed a commit to QilongZhang/sofa-boot that referenced this pull request Jan 30, 2019
@ScienJus @QilongZhang
Parameter xsd and annotation (sofastack#330)
44b51eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leizhiyuan leizhiyuan leizhiyuan approved these changes

@straybirdzls straybirdzls straybirdzls approved these changes

@QilongZhang QilongZhang QilongZhang approved these changes

Assignees

@ScienJus ScienJus

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ScienJus @straybirdzls @QilongZhang @leizhiyuan
0