8000 add extension and extension point support by straybirdzls · Pull Request #340 · sofastack/sofa-boot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add extension and extension point support #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 23, 2019
Merged

add extension and extension point support #340

merged 13 commits into from
Jan 23, 2019

Conversation

straybirdzls
Copy link
Member

fix #339

8000
@straybirdzls straybirdzls added this to the 2.6.0 milestone Jan 17, 2019
@codecov
Copy link
codecov bot commented Jan 17, 2019 •
edited
Loading

Codecov Report

Merging #340 into 2.x will increase coverage by 0.81%.
The diff coverage is 67.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #340      +/-   ##
==========================================
+ Coverage   65.38%   66.19%   +0.81%     
==========================================
  Files          81      129      +48     
  Lines        2233     3804    +1571     
  Branches      285      537     +252     
==========================================
+ Hits         1460     2518    +1058     
- Misses        589      991     +402     
- Partials      184      295     +111
Impacted Files Coverage Δ
.../sofa/runtime/api/client/param/ExtensionParam.java 100% <100%> (ø)
.../runtime/api/client/param/ExtensionPointParam.java 100% <100%> (ø)
...spring/parser/AbstractExtBeanDefinitionParser.java 100% <100%> (ø)
...y/sofa/runtime/ext/client/ExtensionClientImpl.java 100% <100%> (ø)
...alipay/sofa/runtime/ext/component/XMapContext.java 100% <100%> (ø)
...y/sofa/runtime/ext/spring/SpringExtensionImpl.java 100% <100%> (ø)
...java/com/alipay/sofa/common/xmap/XFieldSetter.java 100% <100%> (ø)
...itializer/SofaRuntimeSpringContextInitializer.java 96.87% <100%> (+0.04%) ⬆️
.../com/alipay/sofa/runtime/spi/util/ParserUtils.java 35.29% <35.29%> (ø)
...er/AbstractSingleExtPointBeanDefinitionParser.java 37.5% <37.5%> (ø)
... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2309d64...947bdac. Read the comment docs.

@straybirdzls straybirdzls changed the title add extension and extension point support [WIP] add extension and extension point support Jan 17, 2019
@straybirdzls straybirdzls changed the title [WIP] add extension and extension point support add extension and extension point support Jan 18, 2019
glmapper
glmapper approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor
@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@glmapper glmapper merged commit 2ed1cfd into sofastack:2.x Jan 23, 2019
QilongZhang pushed a commit to QilongZhang/sofa-boot that referenced this pull request Jan 30, 2019
@straybirdzls @QilongZhang
add extension and extension point support (sofastack#340)
7f879a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongZhang QilongZhang QilongZhang approved these changes

@glmapper glmapper glmapper approved these changes

@caojie09 caojie09 caojie09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@straybirdzls @QilongZhang @glmapper @caojie09
0