794 check for body validations and class validations #1277
+911
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahilagichani14
commented
Apr 18, 2025
8000
sahilagichani14
commented
Apr 18, 2025
| import java.util.List; | ||
| import java.util.Set; | ||
| import sootup.core.model.FieldModifier; | ||
| import sootup.core.model.SootClass; | ||
| import sootup.core.model.SootField; | ||
|
|
||
| /** Validator that checks for impossible combinations of field modifiers */ | ||
| public class FieldModifiersValidator implements ClassValidator { |
There was a problem hiding this comment.
I reused this class, which was already there, or should I create another separate class for this wrapper?
There was a problem hiding this comment.
This is linked to #322
You can directly address the other validators as well.
swissiety
approved these changes
May 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1277 +/- ##
=============================================
- Coverage 71.31% 70.35% -0.97%
Complexity 19 19
=============================================
Files 446 453 +7
Lines 18439 18703 +264
Branches 2947 3033 +86
=============================================
+ Hits 13150 13158 +8
- Misses 4175 4430 +255
- Partials 1114 1115 +1
🚀 New features to boost your workflow:
|
…binations' into 794-check-for-valid-modifier-combinations
# Conflicts: # sootup.core/src/main/java/sootup/core/jimple/JimpleIR.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.