10000 Fix not being able to import Wallet interface by Tristyn · Pull Request #1916 · solana-foundation/anchor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix not being able to import Wallet interface #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix not being able to import Wallet interface #1916

wants to merge 3 commits into from

Conversation

Tristyn
Copy link
Contributor
@Tristyn Tristyn commented May 23, 2022 •
edited
Loading

This exports Wallet interface, NodeWallet class. Previously the Wallet interface was inaccessible

Also gave workspace a type Record<string, Program>

This is a breaking change. Should I fix tests?

@armaniferrante
Copy link
Collaborator

Please run prettier

yarn run v1.22.18
$ prettier src/** tests/** --check
Checking formatting...
[warn] src/index.ts
[warn] Code style issues found in the above file(s). Forgot to run Prettier?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

@Henry-E
Copy link
Henry-E commented Dec 6, 2022

Not sure whether this PR is still needed or not?

@Tristyn
Copy link
Contributor Author
Tristyn commented Mar 1, 2023

I think so but it's nbd. Anchor exports Wallet which is just a clone of NodeWallet, kinda silly

Feel free to close though if you don't want to clean up and merge this

@Henry-E
Copy link
Henry-E commented Mar 1, 2023

Recently when doing the VersionedTransaction update I did notice that the Wallet interface doesn't show up in anchor's ts docs. But in general, I don't really understand enough about what's happening in this PR to make a judgement call or clean it up

@Tristyn
Copy link
Contributor Author
Tristyn commented Mar 1, 2023

Lets pretend this never happened ;)
the-simpsons-homer-simpson

@Tristyn Tristyn closed this Mar 1, 2023
@mwrites mwrites mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
probably will close
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tristyn @armaniferrante @Henry-E
0