This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Fix mislabelled mul64_imm and mul64_reg #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MUL64_IMM and MUL64_REG opcodes were both mislabelled in the comments as div64 which also stated that they perform an operation equivalent `/=`. This commit accurately labels them both as mul64 and performing an operation equivalent to `*=`.
neg64 was also mislabelled a 702E s requiring two operands `dst, src` when it only takes in `dst`. This is now fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUL64_IMM and MUL64_REG opcodes were both mislabelled in the comments as div64 which also stated that they perform an operation equivalent
/=. This commit accurately labels them both as mul64 and performing an operation equivalent to*=.