8000 Rpc: enable getConfirmedSignaturesForAddress2 to return confirmed (not yet finalized) data (bp #16281) by mergify[bot] · Pull Request #16292 · solana-labs/solana · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Rpc: enable getConfirmedSignaturesForAddress2 to return confirmed (not yet finalized) data (bp #16281) #16292

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Rpc: enable getConfirmedSignaturesForAddress2 to return confirmed (not yet finalized) data (bp #16281) #16292

merged 1 commit into from
Apr 1, 2021

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Apr 1, 2021

This is an automatic backport of pull request #16281 done by Mergify.

Cherry-pick of da27aca has failed:

On branch mergify/bp/v1.5/pr-16281
Your branch is up to date with 'origin/v1.5'.

You are currently cherry-picking commit da27acabc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cli/src/cluster_query.rs
	modified:   client/src/rpc_client.rs
	modified:   client/src/rpc_config.rs
	modified:   docs/src/developing/clients/jsonrpc-api.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   client/src/rpc_response.rs
	both modified:   core/src/rpc.rs
	both modified:   ledger/src/blockstore.rs

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot added conflicts automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels Apr 1, 2021
@mergify
Copy link
Contributor Author
mergify bot commented Apr 1, 2021

automerge label removed due to a CI failure

@CriesofCarrots
Rpc: enable getConfirmedSignaturesForAddress2 to return confirmed (no…
1c029b5 
…t yet finalized) data (#16281)

* Update blockstore method to allow return of unfinalized signature

* Support confirmed sigs in getConfirmedSignaturesForAddress2

* Add deprecated comments

* Update docs

* Enable confirmed transaction-history in cli

* Return real confirmation_status; fill in not-yet-finalized block time if possible

(cherry picked from commit da27aca)
@CriesofCarrots CriesofCarrots force-pushed the mergify/bp/v1.5/pr-16281 branch from 899f57f to 1c029b5 Compare April 1, 2021 16:31
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Apr 1, 2021
@CriesofCarrots CriesofCarrots merged commit 7e480df into v1.5 Apr 1, 2021
@mergify mergify bot deleted the mergify/bp/v1.5/pr-16281 branch April 1, 2021 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CriesofCarrots
0