This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Revive code coverage #1106
Merged
Revive code coverage #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Green checkmark is a lie. @aeyakovenko, why are errors on the nightly build ignored? |
|
The cache poisoned one of the builds. But it only failed for nightly and
didn’t make sense so it looked like a possible compiler error. That’s why
it’s off
On Sat, Sep 1, 2018 at 2:30 PM Greg Fitzgerald ***@***.***> wrote:
Green checkmark is a lie. @aeyakovenko <https://github.com/aeyakovenko>,
why are errors on the nightly build ignored?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1106 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA-ztpx44_y25h3t_stv-zen92NSXElnks5uWya1gaJpZM4WWaez>
.
|
bd6b353 to
eef8eac
Compare
bbf10c0 to
2b3c2b4
Compare
8878794 to
e84de86
Compare
e84de86 to
c9dca96
Compare
Need clang-dev, not llvm-dev because cargo-cov looks for libprofile in a clang installation directory.
c9dca96 to
777a167
Compare
|
💔 Unable to automerge due to CI failure |
2087325 to
c9a1768
Compare
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
wen-coding
pushed a commit
to wen-coding/solana
that referenced
this pull request
May 7, 2024
This was erronously deemed as unnecessary and removed in: anza-xyz#864 The commit partially reverts solana-labs#864 and adds back socket-addr dedup.
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
May 7, 2024
This was erronously deemed as unnecessary and removed in: anza-xyz#864 The commit partially reverts solana-labs#864 and adds back socket-addr dedup.
yihau
pushed a commit
that referenced
this pull request
May 14, 2024
… of #1106) (#1225) reverts back in SocketAddr dedup in retransmit stage (#1106) This was erronously deemed as unnecessary and removed in: anza-xyz#864 The commit partially reverts #864 and adds back socket-addr dedup. (cherry picked from commit fbe1dbc) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
May 15, 2024
… of solana-labs#1106) (solana-labs#1225) reverts back in SocketAddr dedup in retransmit stage (solana-labs#1106) This was erronously deemed as unnecessary and removed in: anza-xyz#864 The commit partially reverts solana-labs#864 and adds back socket-addr dedup. (cherry picked from commit fbe1dbc) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-cov 0.0.5 was recently published, which fixed the compilation issue on Rust nightly. This PR takes another stab at bringing code coverage back to life.
Towards #433